I’ve struggled to get Screen Sharing to work from my Mac Mini for quite some time now. Turns out that if you have Firewall turned on, you also need to explicitly add the “Screen Sharing” app to the allow list. Basically, you should have two items visible on the list.